Skip to content

chore: promote staging to staging-promote/d33fecb1-24797241283 (2026-04-23 06:04 UTC) - #2882

Merged
henrypark133 merged 2 commits into
mainfrom
staging-promote/b5ba7496-24819641779
Apr 29, 2026
Merged

henrypark133 merged 2 commits into
mainfrom
staging-promote/b5ba7496-24819641779

Conversation

@ironclaw-ci

@ironclaw-ci ironclaw-ci Bot commented Apr 23, 2026 •

Copy link
Copy Markdown
Contributor

Auto-promotion from staging CI

Batch range: 7fb41555a9e55677d1aaea29ca567a5b369c2b05..b5ba7496f0bce5178ee925761c24b12fbdde8d05
Promotion branch: staging-promote/b5ba7496-24819641779
Base: staging-promote/d33fecb1-24797241283
Triggered by: Staging CI batch at 2026-04-23 06:04 UTC

Commits in this batch (82):

Current commits in this promotion (2)

Current base: staging-promote/d33fecb1-24797241283
Current head: staging-promote/b5ba7496-24819641779
Current range: origin/staging-promote/d33fecb1-24797241283..origin/staging-promote/b5ba7496-24819641779

Auto-updated by staging promotion metadata workflow

Waiting for gates:

  • Tests: pending
  • E2E: pending
  • Claude Code review: pending (will post comments on this PR)

Auto-created by staging-ci workflow

serrrfirat and others added 2 commits April 23, 2026 08:31
* fix(web): use conversation-only chat sidebar

* fix(ci): use unwrap_or_default() for clippy compliance

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* fix(engine): enforce tool use for stop/pause/cancel commands (#2808)

The LLM was narrating about calling mission_pause/mission_list instead of
actually executing them because neither the tool-intent nudge nor the
execution obligation recognized stop/pause/cancel as action commands.

- Add stop/pause/cancel/halt/disable to signals_tool_intent ACTION_VERBS
  so the nudge fires when the LLM says "I'll pause the mission"
- Add stop/pause/cancel phrases to signals_execution_intent EXEC_PHRASES
  so the obligation system forces tool calls for "stop it", "pause the X"
- Add bare imperative detection (startswith) for "stop", "stop pinging",
  "pause", "cancel" — avoids false positives like "I can't stop"
- Add 5 regression tests covering true positives and false negatives

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address review findings (iteration 1)

- Add missing "please halt " to EXEC_PHRASES for consistency with
  please stop/pause/cancel
- Strip trailing punctuation from bare commands so "Stop." and "cancel!"
  are detected
- Add 2 regression tests covering both fixes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix(engine): address gemini-code-assist review — halt/disable consistency (#2814)

- Add "halt it/that/this/the" and "disable it/that/this/the" to
  EXEC_PHRASES for consistency with signals_tool_intent
- Add "please disable " to polite execution phrases
- Add "disable" to BARE_COMMANDS and IMPERATIVE_STARTS
- Add regression test for halt/disable execution intent phrases

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added scope: channel/web Web gateway channel size: L 200-499 changed lines risk: medium Business logic, config, or moderate-risk modules contributor: core 20+ merged PRs labels Apr 23, 2026
@claude

claude Bot commented Apr 23, 2026

Copy link
Copy Markdown

Code review

Found 3 issues:

  1. [MEDIUM:HIGH] DRY violation — duplicate command constants in Python. The signals_execution_intent() function redefines IMPERATIVE_STARTS and BARE_COMMANDS as local variables at lines 184–185, but these lists duplicate the command patterns (stop, pause, cancel, halt, disable) already added to EXEC_PHRASES above. If the command list needs to be updated, it must be changed in two places, creating maintenance risk and divergence. Extract these constants to module level once.

https://github.com/anthropics/ironclaw/blob/bf59dcb2f74acccde1c986ea83c36aa2bbe7104d/crates/ironclaw_engine/orchestrator/default.py#L184-L185

  1. [MEDIUM:HIGH] Inefficient Date object allocation in sort comparator. The threads.sort() call at line 398 creates a new Date object on every comparison (new Date(b.updated_at).getTime() twice per comparison). For N threads, this results in O(N log N) unnecessary allocations. Parse updated_at once before sorting, or use string comparison directly if the timestamp format is ISO-8601.

https://github.com/anthropics/ironclaw/blob/bf59dcb2f74acccde1c986ea83c36aa2bbe7104d/crates/ironclaw_gateway/static/js/core/history.js#L398

  1. [LOW:MEDIUM] Performance — list allocations in hot path. If signals_execution_intent() is called on every message in the agent loop (lines 184–185), the IMPERATIVE_STARTS and BARE_COMMANDS lists are recreated each time. Move them to module-level constants to avoid repeated allocations.

https://github.com/anthropics/ironclaw/blob/bf59dcb2f74acccde1c986ea83c36aa2bbe7104d/crates/ironclaw_engine/orchestrator/default.py#L184-L185

Base automatically changed from staging-promote/d33fecb1-24797241283 to main April 29, 2026 04:09
@henrypark133
henrypark133 merged commit b5ba749 into main Apr 29, 2026
56 of 67 checks passed
@henrypark133
henrypark133 deleted the staging-promote/b5ba7496-24819641779 branch April 29, 2026 04:09

This branch had an error being deployed

1 failed and 5 inactive deployments
venice-ironclaw / production — b5ba7496 Deployed Apr 23, 2026 by railway-app[bot]
Ironclaw-QA / production — b5ba7496 Deployed Apr 23, 2026 by railway-app[bot]
ironclaw-nearai / production — b5ba7496 Deployed Apr 23, 2026 by railway-app[bot]
Near Foundation Ironclaw / production — b5ba7496 Deployed Apr 23, 2026 by railway-app[bot]
cosmose-ironclaw / production — b5ba7496 Deployed Apr 23, 2026 by railway-app[bot]
humble-cat / staging-cameron — b5ba7496 Deployed Apr 23, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: channel/web Web gateway channel size: L 200-499 changed lines staging-promotion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants